Skip to content

validate os updates and os profiles on dry-run for empty setup (#47408)#47499

Merged
MagnusHJensen merged 1 commit into
rc-minor-fleet-v4.87.0from
os-updates-dry-run-cp
Jun 12, 2026
Merged

validate os updates and os profiles on dry-run for empty setup (#47408)#47499
MagnusHJensen merged 1 commit into
rc-minor-fleet-v4.87.0from
os-updates-dry-run-cp

Conversation

@MagnusHJensen

Copy link
Copy Markdown
Member

Related issue: CP: #47408

  • QA'd all new/changed functionality manually

Summary by CodeRabbit

  • Bug Fixes
  • Enhanced validation to detect and prevent conflicting OS update configurations when both managed updates and custom configuration profiles attempt to manage OS updates.
  • Tests
  • Added automated tests covering detection of conflicts between managed OS updates and configuration profile contents for macOS/iOS and Windows.

<!-- Add the related story/sub-task/bug number, like Resolves #123, or
remove if NA -->
**Related issue:** Resolves #47364 

Unreleased bug for 4.87

- [x] QA'd all new/changed functionality manually

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

* **Bug Fixes**
* Enhanced validation to detect and prevent conflicting OS update
configurations when both managed updates and custom configuration
profiles attempt to manage OS updates.
* **Tests**
* Added automated tests covering detection of conflicts between managed
OS updates and configuration profile contents for macOS/iOS and Windows.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@MagnusHJensen MagnusHJensen requested a review from a team as a code owner June 12, 2026 11:08
@codecov

codecov Bot commented Jun 12, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 70.73171% with 12 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (rc-minor-fleet-v4.87.0@8b47ac6). Learn more about missing BASE report.

Files with missing lines Patch % Lines
pkg/spec/gitops.go 70.73% 6 Missing and 6 partials ⚠️
Additional details and impacted files
@@                    Coverage Diff                    @@
##             rc-minor-fleet-v4.87.0   #47499   +/-   ##
=========================================================
  Coverage                          ?   67.18%           
=========================================================
  Files                             ?     2914           
  Lines                             ?   226729           
  Branches                          ?    11823           
=========================================================
  Hits                              ?   152328           
  Misses                            ?    60618           
  Partials                          ?    13783           
Flag Coverage Δ
backend 68.82% <70.73%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@MagnusHJensen MagnusHJensen merged commit c6b75af into rc-minor-fleet-v4.87.0 Jun 12, 2026
37 checks passed
@MagnusHJensen MagnusHJensen deleted the os-updates-dry-run-cp branch June 12, 2026 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants